Fix for C99; Add tests #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
==========================================
- Coverage 95.80% 92.52% -3.28%
==========================================
Files 61 67 +6
Lines 8143 9277 +1134
Branches 0 9277 +9277
==========================================
+ Hits 7801 8584 +783
- Misses 342 422 +80
- Partials 0 271 +271 ☔ View full report in Codecov by Sentry. |
justsmth
force-pushed
the
testing-c-std
branch
from
7ac3156 to
9b930c2
Compare
skmcgrail
approved these changes
Sep 4, 2024
andrewhop
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
On macos, the
collect_build_src.shwas not identifyingrefcount_lock.cas a source file b/c our automation performs the final build using the (default) C11 standard. However,refcount_lock.cis still needed for C99 builds, but it was not listed.Description of changes:
collect_build_src.shso that it will always include bothrefcount_lock.candrefcount_c11.c(although only one of these will actually be useful to any specific build).AWS_LC_SYS_C_STDto either99or11results in a successful build.cc_buildersource listing so thatrefcount_lock.cis included.Testing:
cc_buildersource listings it produces match what's in this PR: https://github.com/aws/aws-lc-rs/actions/runs/10700676326By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.